Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(version): use npmClientArgs in npm install after lerna version #417

Merged
merged 2 commits into from Nov 22, 2022

Conversation

ghiscoding
Copy link
Member

@ghiscoding ghiscoding commented Nov 19, 2022

Description

As per Lerna PR 3434

Adds configured npmClientArgs to the npm install command that happens at the end of lerna version.

Motivation and Context

Addresses Lerna issue 3386

lerna version does not take npmClientArgs into account

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Merging #417 (ffd37a3) into main (267fced) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
+ Coverage   97.31%   97.31%   +0.01%     
==========================================
  Files         146      146              
  Lines        4335     4336       +1     
  Branches     1004     1005       +1     
==========================================
+ Hits         4218     4219       +1     
  Misses        117      117              
Impacted Files Coverage Δ
...kages/cli/src/cli-commands/cli-version-commands.ts 100.00% <ø> (ø)
...ackages/version/src/lib/update-lockfile-version.ts 100.00% <100.00%> (ø)
packages/version/src/version-command.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 43e5dcd into main Nov 22, 2022
@ghiscoding ghiscoding deleted the feat/use-npm-client-args-in-version branch November 22, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant