Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run): warn on incompatible arguments with useNx #3326

Merged
merged 3 commits into from Sep 20, 2022

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Sep 13, 2022

Makes lerna run warn the user when --sort, --no-sort, --include-dependencies, and --parallel are used with a nx.json file.

Description

Motivation and Context

This change is necessary to communicate that specific options are not available when using nx with a custom nx.json file.

How Has This Been Tested?

This has been tested manually and covered by e2e tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj marked this pull request as ready for review September 15, 2022 13:36
@fahslaj fahslaj force-pushed the run-warn-on-incompatible-args branch from 1dc2d11 to 5ddf597 Compare September 19, 2022 16:12
@fahslaj fahslaj force-pushed the run-warn-on-incompatible-args branch from 5ddf597 to 79dc068 Compare September 20, 2022 17:28
@JamesHenry JamesHenry changed the title feat(run): Warn on incompatible arguments with useNx fix(run): warn on incompatible arguments with useNx Sep 20, 2022
@JamesHenry JamesHenry merged commit ebf6542 into lerna:main Sep 20, 2022
@fahslaj fahslaj deleted the run-warn-on-incompatible-args branch September 27, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants