Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run): warn on incompatible arguments with useNx #343

Merged
merged 2 commits into from Sep 21, 2022

Conversation

ghiscoding
Copy link
Member

@ghiscoding ghiscoding commented Sep 21, 2022

Description

As per Lerna PR

Makes lerna run warn the user when --sort, --no-sort, --include-dependencies, and --parallel are used with a nx.json file.

Motivation and Context

As per Lerna PR 3326

This change is necessary to communicate that specific options are not available when using nx with a custom nx.json file.

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #343 (52bff4c) into main (b84384a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
+ Coverage   96.12%   96.15%   +0.03%     
==========================================
  Files         145      145              
  Lines        4252     4253       +1     
  Branches      895      896       +1     
==========================================
+ Hits         4087     4089       +2     
+ Misses        165      164       -1     
Impacted Files Coverage Δ
packages/run/src/run-command.ts 95.59% <100.00%> (+0.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit eb008af into main Sep 21, 2022
@ghiscoding ghiscoding deleted the bugfix/run-warn-on-incompatible-args branch September 21, 2022 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant