Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(version): add --signoff git flag #2897

Merged
merged 2 commits into from Dec 13, 2022

Conversation

petermetz
Copy link
Contributor

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Description

Provide a CLI flag to enable signing off on the git commits made by lerna version.
Currently this is not supported, only gpg signatures are, which is a different thing entirely despite the very similar sounding name.
https://stackoverflow.com/a/64840893/698470

Motivation and Context

When issuing releases on a project I help maintain, there's a check for DCO and this currently cannot be satisfied unless you manually jerry rig the commit after the fact, but this then leads to your npm packages being published with a revision of the code that you disappear right after with a force push while cleaning up.

How Has This Been Tested?

I didn't, the linter has 500+ errors so I couldn't run the tests locally. I was hoping the CI here would be set up to run the automated tests (which I did add so there is test coverage I just never ran it locally)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [] All new and existing tests passed.

ghiscoding added a commit to lerna-lite/lerna-lite that referenced this pull request Feb 11, 2022
@ghiscoding
Copy link

ghiscoding commented Feb 11, 2022

hey guys if that interests you, I replicated this change in Lerna-Lite fork

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@JamesHenry JamesHenry merged commit 93b24d7 into lerna:main Dec 13, 2022
@JamesHenry
Copy link
Member

Thank you very much for this @petermetz! I'm sorry it sat in limbo for so long while the project went through a transitional period

@petermetz petermetz deleted the feat-version-git-signoff branch December 14, 2022 18:38
@petermetz
Copy link
Contributor Author

Thank you very much for this @petermetz! I'm sorry it sat in limbo for so long while the project went through a transitional period

@JamesHenry No worries at all, I know how hard it is to be a maintainer sometimes! Very much appreciated that you came around to it eventually, regardless of how much time it took!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants