fix(utils): orphaned child process on Windows (#3156)

Co-authored-by: Fery Wardiyanto <ferywardiyanto@gmail.com>
lerna · Jun 7, 2022 · 7e69e9e · 7e69e9e
1 parent 897caee
commit 7e69e9e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/utils/npm-run-script/__tests__/npm-run-script.test.js b/utils/npm-run-script/__tests__/npm-run-script.test.js
@@ -30,6 +30,7 @@ describe("npm-run-script", () => {
         env: {},
         pkg: config.pkg,
         reject: true,
+        windowsHide: false,
       });
     });
 
@@ -51,6 +52,7 @@ describe("npm-run-script", () => {
         env: {},
         pkg: config.pkg,
         reject: false,
+        windowsHide: false,
       });
     });
 
@@ -71,6 +73,7 @@ describe("npm-run-script", () => {
         env: {},
         pkg: config.pkg,
         reject: true,
+        windowsHide: false,
       });
     });
   });
@@ -98,6 +101,7 @@ describe("npm-run-script", () => {
           env: {},
           pkg: config.pkg,
           reject: true,
+          windowsHide: false,
         },
         config.pkg.name
       );
@@ -125,6 +129,7 @@ describe("npm-run-script", () => {
           env: {},
           pkg: config.pkg,
           reject: false,
+          windowsHide: false,
         },
         undefined
       );

diff --git a/utils/npm-run-script/npm-run-script.js b/utils/npm-run-script/npm-run-script.js
@@ -28,6 +28,7 @@ function npmRunScriptStreaming(script, { args, npmClient, pkg, prefix, reject =
 
 function makeOpts(pkg, reject) {
   return Object.assign(getNpmExecOpts(pkg), {
+    windowsHide: false,
     reject,
   });
 }