Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): highlight version prop required in lerna.json #486

Merged
merged 1 commit into from Feb 20, 2023

Conversation

ghiscoding
Copy link
Member

Description

highlight the fact that version is a required property to exist in the lerna.json config

Motivation and Context

We should highlight the fact that version property is a required field that needs to be defined in lerna.json, there was a previous PR #431 that now throws an error but it wasn't clear enough that the user must really include such field in its lerna.json config. Closes #485

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- highlight the fact that `version` is a required property to exist in the `lerna.json` config
- closes #485
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #486 (37e6ab5) into main (32d06de) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #486   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         151      151           
  Lines        4531     4531           
  Branches     1058     1058           
=======================================
  Hits         4414     4414           
  Misses        117      117           
Impacted Files Coverage Δ
packages/core/src/command.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 8720397 into main Feb 20, 2023
@ghiscoding ghiscoding deleted the bugfix/clearer-version-mode branch February 20, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seems like --yes stopped working
1 participant