Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run): fully defer to Nx for dep detection when nx.json exists #360

Merged
merged 1 commit into from Oct 2, 2022

Conversation

ghiscoding
Copy link
Member

Description

As per original Lerna PR 3345

  • Only sends "targetDependencies" from Lerna to Nx when nx.json does not exist.
  • Updates the warning when using --include-dependencies to indicate that Lerna will send Nx additional dependencies to run.
  • Updates docs to be more clear on the differing behavior.
  • Adds a note to the docs when installing Nx that lerna run will behave differently and links to the page describing the differences.

Motivation and Context

stay in sync with original Lerna

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Merging #360 (0657aa4) into main (0fc9af9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #360   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files         145      145           
  Lines        4266     4266           
  Branches      975      975           
=======================================
  Hits         4102     4102           
  Misses        164      164           
Impacted Files Coverage Δ
packages/run/src/run-command.ts 95.61% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit d68f19a into main Oct 2, 2022
@ghiscoding ghiscoding deleted the bugfix/only-send-target-deps-if-no-nxjson branch October 2, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant