Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publish): include all deps in package graph by default, allow no-sort #277

Merged
merged 3 commits into from Jul 27, 2022

Conversation

ghiscoding
Copy link
Member

Description

As per original Lerna PR 3263

Users can still opt into the old behavior of ignoring devDependencies until v6 by passing --graph-type=dependencies, or setting it in their lerna.json.

Note: For the unit test updates it's down to the fact that in the relevant fixture, package-3 has a devDependency on package-2, so it now comes after it in the ordering.

Motivation and Context

keep in sync with Lerna's codebase

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #277 (9e3b547) into main (fb1852d) will decrease coverage by 0.01%.
The diff coverage is 94.12%.

@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
- Coverage   93.84%   93.84%   -0.00%     
==========================================
  Files         142      142              
  Lines        4105     4118      +13     
  Branches      848      852       +4     
==========================================
+ Hits         3852     3864      +12     
- Misses        253      254       +1     
Impacted Files Coverage Δ
packages/core/src/command.ts 94.03% <ø> (ø)
packages/core/src/package.ts 99.38% <ø> (ø)
packages/publish/src/publish-command.ts 96.75% <94.12%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb1852d...9e3b547. Read the comment docs.

@ghiscoding ghiscoding merged commit 3229e77 into main Jul 27, 2022
@ghiscoding ghiscoding deleted the feat/publish-graph-type-and-sorting branch July 27, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant