Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): inherit stdio for lerna version lifecycle scripts #276

Merged
merged 1 commit into from Jul 27, 2022

Conversation

ghiscoding
Copy link
Member

@ghiscoding ghiscoding commented Jul 27, 2022

Description

stdio should be inherited so the script can be interactive while executing lerna version

Motivation and Context

keep in sync with Lerna, this came from Lerna PR 3264

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #276 (b66ed70) into main (fb1852d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files         142      142           
  Lines        4105     4105           
  Branches      848      848           
=======================================
  Hits         3852     3852           
  Misses        253      253           
Impacted Files Coverage Δ
packages/version/src/version-command.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb1852d...b66ed70. Read the comment docs.

@ghiscoding ghiscoding merged commit 9c3625d into main Jul 27, 2022
@ghiscoding ghiscoding deleted the bugfix/version-stdio branch July 27, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant