Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): add Prettier to the project, expand on #168 #182

Merged
merged 16 commits into from Jun 7, 2022

Commits on May 18, 2022

  1. Configuration menu
    Copy the full SHA
    509ca33 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. Configuration menu
    Copy the full SHA
    cf35dc6 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. feat(version): support for updating pnpm-lock.yaml, expand on #168

    - takes PR #168 and adresses all comments provided in the original PR
    - fixed npm lockfile that got broken by original PR, I took the same approach as the pnpm lock file update to fix the npm lock file update. Both updates are now very similar and easier to read
    - removed `preferred-pm` since I would prefer to not use any extra dependencies, and I think that also fixed the unit tests since they weren't being detected properly
    - added a prettier VSCode setting (setup) and also fixed couple of places where prettier wasn't doing a good job
    ghiscoding committed May 26, 2022
    Configuration menu
    Copy the full SHA
    ee1a964 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e03ceb0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9bb5151 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    afafb9c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2930282 View commit details
    Browse the repository at this point in the history
  6. chore: sort imports

    ghiscoding committed May 26, 2022
    Configuration menu
    Copy the full SHA
    ef2d65d View commit details
    Browse the repository at this point in the history
  7. refactor: improve lock file reading by adding npmClient

    - it will still work when undefined but it will speed up the process when `npmClient` is already specified in `lerna.json`, for example no need to try loading npm lock file when user defined `pnpm` as client
    ghiscoding committed May 26, 2022
    Configuration menu
    Copy the full SHA
    4124603 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2022

  1. tests: add more test cases & add noUpdateRootLockFile flag

    - found some issues with `workspace:` protocol when adding more use cases (ie `workspace:*`), it's not perfect but it should cover 95% of use cases. The case that I know won't work, but is rare, is if the user decide to switch from a workspace version (ie `workspace:^1.2.3`) to a fixed workspace (ie `workspace:^`) then it will end up updating it anyway, it's not a huge deal and won't break anything and running pnpm install will fix it, which is why I decided to add `--no-update-root-lock-file` flag)
    ghiscoding committed May 28, 2022
    Configuration menu
    Copy the full SHA
    917fef3 View commit details
    Browse the repository at this point in the history
  2. docs: fix typos

    ghiscoding committed May 28, 2022
    Configuration menu
    Copy the full SHA
    a6a9ae9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1fac28c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b912900 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Configuration menu
    Copy the full SHA
    f8ba877 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b02a5e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    00ce3e0 View commit details
    Browse the repository at this point in the history