-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): add Prettier to the project, expand on #168 #182
Merged
Commits on May 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 509ca33 - Browse repository at this point
Copy the full SHA 509ca33View commit details
Commits on May 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for cf35dc6 - Browse repository at this point
Copy the full SHA cf35dc6View commit details
Commits on May 26, 2022
-
feat(version): support for updating
pnpm-lock.yaml
, expand on #168- takes PR #168 and adresses all comments provided in the original PR - fixed npm lockfile that got broken by original PR, I took the same approach as the pnpm lock file update to fix the npm lock file update. Both updates are now very similar and easier to read - removed `preferred-pm` since I would prefer to not use any extra dependencies, and I think that also fixed the unit tests since they weren't being detected properly - added a prettier VSCode setting (setup) and also fixed couple of places where prettier wasn't doing a good job
Configuration menu - View commit details
-
Copy full SHA for ee1a964 - Browse repository at this point
Copy the full SHA ee1a964View commit details -
Configuration menu - View commit details
-
Copy full SHA for e03ceb0 - Browse repository at this point
Copy the full SHA e03ceb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bb5151 - Browse repository at this point
Copy the full SHA 9bb5151View commit details -
Configuration menu - View commit details
-
Copy full SHA for afafb9c - Browse repository at this point
Copy the full SHA afafb9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2930282 - Browse repository at this point
Copy the full SHA 2930282View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef2d65d - Browse repository at this point
Copy the full SHA ef2d65dView commit details -
refactor: improve lock file reading by adding
npmClient
- it will still work when undefined but it will speed up the process when `npmClient` is already specified in `lerna.json`, for example no need to try loading npm lock file when user defined `pnpm` as client
Configuration menu - View commit details
-
Copy full SHA for 4124603 - Browse repository at this point
Copy the full SHA 4124603View commit details
Commits on May 28, 2022
-
tests: add more test cases & add
noUpdateRootLockFile
flag- found some issues with `workspace:` protocol when adding more use cases (ie `workspace:*`), it's not perfect but it should cover 95% of use cases. The case that I know won't work, but is rare, is if the user decide to switch from a workspace version (ie `workspace:^1.2.3`) to a fixed workspace (ie `workspace:^`) then it will end up updating it anyway, it's not a huge deal and won't break anything and running pnpm install will fix it, which is why I decided to add `--no-update-root-lock-file` flag)
Configuration menu - View commit details
-
Copy full SHA for 917fef3 - Browse repository at this point
Copy the full SHA 917fef3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6a9ae9 - Browse repository at this point
Copy the full SHA a6a9ae9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fac28c - Browse repository at this point
Copy the full SHA 1fac28cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b912900 - Browse repository at this point
Copy the full SHA b912900View commit details
Commits on Jun 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f8ba877 - Browse repository at this point
Copy the full SHA f8ba877View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b02a5e - Browse repository at this point
Copy the full SHA 6b02a5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 00ce3e0 - Browse repository at this point
Copy the full SHA 00ce3e0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.