Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support clearing fields #70

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danielmarbach
Copy link

Addressed #69

Copy link
Owner

@leonsteinhaeuser leonsteinhaeuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Have you already tested this?

@danielmarbach
Copy link
Author

I didn't have time before my vacation. I'm mostly offline until beginning of August

@leonsteinhaeuser
Copy link
Owner

No problem. Enjoy your vacation. I will take responsibility for the tests.

@leonsteinhaeuser
Copy link
Owner

leonsteinhaeuser commented Sep 25, 2023

@danielmarbach I am sorry it has taken so long. I have been very busy the last few months. I finally had some time to test this and unfortunately the test with the "Date" field does not work as expected.

See (output for: test_user.sh):

"Date": PVTF_lAHOAoeKQc2PEc4ADXso
Updating date field: "Date" with value: null
{errors:[{extensions:{value:null,problems:[{path:[],explanation:Could not coerce value 
ull\ to Date}]},locations:[{line:6,column:9}],message:Variable $fieldValue of type Date! was provided invalid value}]}

@danielmarbach
Copy link
Author

It sounds like it doesn't execute the clear but tries to assign null to the field value. I'm a but removed from this but I can try this give it another look at some point

@goldiegadde
Copy link

Is anyone still workign on this, a very useful feature to have

@danielmarbach
Copy link
Author

Sorry no. Feel free to take it from here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants