fix redis#2010 - stop reconnect after .disconnect()

leibale · Nov 14, 2022 · 3e20b34 · 3e20b34
1 parent d097322
commit 3e20b34
Showing 1 changed file with 12 additions and 7 deletions.
diff --git a/packages/client/lib/client/socket.ts b/packages/client/lib/client/socket.ts
@@ -105,6 +105,7 @@ export default class RedisSocket extends EventEmitter {
             throw new Error('Socket already opened');
         }
 
+        this.#isOpen = true;
         return this.#connect();
     }
 
@@ -116,7 +117,6 @@ export default class RedisSocket extends EventEmitter {
             }
 
             try {
-                this.#isOpen = true;
                 this.#socket = await this.#createSocket();
                 this.#writableNeedDrain = false;
                 this.emit('connect');
@@ -142,7 +142,7 @@ export default class RedisSocket extends EventEmitter {
                 await promiseTimeout(retryIn);
             }
             retries++;
-        } while (!this.#isReady);
+        } while (this.#isOpen && !this.#isReady);
     }
 
     #createSocket(): Promise<net.Socket | tls.TLSSocket> {
@@ -203,6 +203,8 @@ export default class RedisSocket extends EventEmitter {
         this.#isReady = false;
         this.emit('error', err);
 
+        if (!this.#isOpen) return;
+
         this.#connect(true).catch(() => {
             // the error was already emitted, silently ignore it
         });
@@ -219,14 +221,17 @@ export default class RedisSocket extends EventEmitter {
     }
 
     disconnect(): void {
-        if (!this.#socket) {
+        if (!this.#isOpen) {
             throw new ClientClosedError();
-        } else {
-            this.#isOpen = this.#isReady = false;
         }
 
-        this.#socket.destroy();
-        this.#socket = undefined;
+        this.#isOpen = this.#isReady = false;
+
+        if (this.#socket) {
+            this.#socket.destroy();
+            this.#socket = undefined;
+        }
+
         this.emit('end');
     }