This repository has been archived by the owner on Dec 26, 2023. It is now read-only.
check for TagsRegex being an empty string before throwing an error #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this needs further work - creation of new workspaces works as expected with the correct trigger patterns, but attempting to update does not seem to change from |
|
With this last commit, this appears to work as expected for creating and updating workspaces! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a tweak that I had to make in order to allow workspaces with
TriggerPatternsto be created via the tfe_workspace resource from the TFE provider. It seems that this value may be coming in as an empty string if not passed, which causes this error to be thrown, and which seems to get otf a bit confused (it will attempt to repeatedly try to create the workspace, but fail, and I think it queues up further plans? I ended up having to kill off otf and start fresh if i had an apply running trying to create workspaces in this way)!Currently running this fork and I am able to create these workspaces as expected! (edit: later, testing updating workspaces, this appears to not work as expected)
Feel free to tweak if necessary, or let me know if there are any other ways you might want this case handled!