feat: Add Webhook Hostname (#668) #670

arcdigital · 2023-12-14T18:59:59Z

No description provided.

internal/daemon/daemon.go

leg100 · 2023-12-16T09:51:46Z

@arcdigital Looks good. I've made a few updates:

Added unit tests that test the behaviour you reported to me in Slack
Set the webhook hostname for Github Apps as well (they're managed separately from per-repo webhooks)
Changed the logging key from webhookHostname to webhook_hostname (keeps it consistent with other multi word logging keys).

🤖 I have created a release *beep* *boop* --- ## [0.2.4](v0.2.3...v0.2.4) (2023-12-16) ### Features * Add Webhook Hostname ([#668](#668)) ([#670](#670)) ([f2dc7e9](f2dc7e9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

leg100 reviewed Dec 15, 2023

View reviewed changes

internal/daemon/daemon.go Outdated Show resolved Hide resolved

leg100 reviewed Dec 15, 2023

View reviewed changes

internal/daemon/daemon.go Outdated Show resolved Hide resolved

arcdigital force-pushed the 668-add-webhook-hostname branch from 6983e96 to ec7158d Compare December 15, 2023 19:53

Add Webhook Hostname (leg100#668)

0244378

arcdigital force-pushed the 668-add-webhook-hostname branch from ec7158d to 0244378 Compare December 15, 2023 20:49

Add tests

b7e2bf2

leg100 changed the title ~~Add Webhook Hostname (#668)~~ feat: Add Webhook Hostname (#668) Dec 16, 2023

Wrong github manifest field

3571645

leg100 merged commit f2dc7e9 into leg100:master Dec 16, 2023
5 checks passed

github-actions bot mentioned this pull request Dec 16, 2023

chore(master): release 0.2.4 #674

Merged

leg100 mentioned this pull request Dec 16, 2023

Webhooks: Ability to change hostname #668

Closed

Provide feedback