Jest tests on UI #6751
Merged
Jest tests on UI #6751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylavoie
added
the
waiting-for-user
ylavoie
removed
the
waiting-for-user
ylavoie
force-pushed
the
jest
branch
4 times, most recently
from
b99e642
to
f2d241d
Compare
ylavoie
added
waiting-for-user
ylavoie
force-pushed
the
jest
branch
4 times, most recently
from
60dc68c
to
2458d4a
Compare
ylavoie
added
the
waiting-for-user
ylavoie
force-pushed
the
jest
branch
4 times, most recently
from
5623b55
to
ce9920f
Compare
ylavoie
force-pushed
the
jest
branch
5 times, most recently
from
c1031fc
to
5b55e17
Compare
ylavoie
force-pushed
the
jest
branch
3 times, most recently
from
84cce3f
to
aab075e
Compare
ylavoie
removed
the
waiting-for-user
ehuelsmann
added
the
waiting-for-user
ehuelsmann
reviewed
Nov 26, 2022
|
@ylavoie is this really ready for merging? Or is this branch still waiting for Coveralls? |
I was waiting. They answered 5 days ago, see lemurheavy/coveralls-public#1662. I'll fix that. |
github-actions
bot
removed
the
waiting-for-user
ylavoie
force-pushed
the
jest
branch
2 times, most recently
from
004a9f2
to
4351b39
Compare
Seems ok now |
ehuelsmann
reviewed
Jan 31, 2023
| @@ -125,16 +125,19 @@ jobs: | |||
| postgres: "13" | |||
| BROWSER: "chrome" | |||
| COVERAGE: 1 | |||
| JOB_COUNT: 2 | |||
There was a problem hiding this comment.
This changes the build matrix, which means adjustment is required for the required jobs on branch protection...
ylavoie
added a commit
to ylavoie/LedgerSMB
that referenced
this pull request
Jan 31, 2023
* Add jest * Simplify GitHub Actions * Coverage with local perl * Do not collect coverage from tests themselves * Ignore coverage in project sources * Fix devel option * Move UI tests to UI * Freshen package-lock
ylavoie
added a commit
to ylavoie/LedgerSMB
that referenced
this pull request
Feb 3, 2023
* Add jest * Simplify GitHub Actions * Coverage with local perl * Do not collect coverage from tests themselves * Ignore coverage in project sources * Fix devel option * Move UI tests to UI * Freshen package-lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
Jest testing isolates the UI and mock all server interaction, allowing robust, repetitive and quick tests