Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade webpack #9485

Merged
merged 2 commits into from Jul 27, 2022
Merged

Upgrade webpack #9485

merged 2 commits into from Jul 27, 2022

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jun 6, 2022 •
edited

Summary

Upgrade webpack and vue-loader to version ranges that no longer produce incompatible installation

Fixes this issue: vuejs/vue-loader#1859

@github-actions
Copy link

github-actions bot commented Jun 6, 2022 •
edited

Build Artifacts

Asset type Download link
PEX file kolibri-0.16.0.dev0_git.20220727170242.pex
Unsigned Windows installer kolibri-0.16.0.dev0+git.20220727170242-unsigned.exe
Debian Package kolibri_0.16.0.dev0+git.20220727170242-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.16.0.dev0+git.20220727170242-0.3.0.dmg
Source Tarball kolibri-0.16.0.dev0+git.20220727170242.tar.gz
WHL file kolibri-0.16.0.dev0+git.20220727170242-py2.py3-none-any.whl

@rtibbles rtibbles added the TODO: needs review Waiting for review label Jun 8, 2022
@rtibbles rtibbles added this to the 0.16.0 milestone Jun 8, 2022
nucleogenesis
nucleogenesis reviewed Jun 9, 2022
View reviewed changes
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the problem this fixes? How do you know that this fixes the issue? Should be good to go in any case if the builds all pass, but just curious how you worked this out in case it helps me with my debugging of various build complaints / bugs.

marcellamaki
marcellamaki approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version upgrades all seem to be working harmoniously. Builds and runs without issue - smoke testing all looks good

@marcellamaki marcellamaki merged commit f8cf5a8 into learningequality:develop Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nucleogenesis nucleogenesis nucleogenesis left review comments

@marcellamaki marcellamaki marcellamaki approved these changes

Assignees
No one assigned
Labels
TODO: needs review Waiting for review
Projects
None yet
Milestone
Kolibri 0.16 Release: Existing Projec...
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rtibbles @nucleogenesis @marcellamaki