Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic QTI zip loading prototype. #8070

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rtibbles
Copy link
Member

Summary

  • Ground work for QTI work
  • Loads content from a QTI zip and then renders, inserting locally referenced files

References

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the work-in-progress Not ready for review label May 10, 2021
@rtibbles rtibbles force-pushed the qti branch 2 times, most recently from 8153bf9 to c4c00bf Compare May 10, 2021 22:20
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at this before but realized I never commented. I gave it another pass and everything looks good to me. This will be an excellent foundation to work from

Comment on lines +40 to +43
return new URL(
relativeHref,
new URL(this.getFilePath(), 'http://b.b/')
).pathname.substring(1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little clarification

Suggested change
return new URL(
relativeHref,
new URL(this.getFilePath(), 'http://b.b/')
).pathname.substring(1);
// iterative URL path construction using dummy domain
return new URL(
relativeHref,
new URL(this.getFilePath(), 'http://example.com/')
).pathname.substring(1);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deliberately used a non-valid TLD to avoid any confusion, but yes.

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

Build Artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-in-progress Not ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants