-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align local pre-commit with CI-based linting (Tox and Travis) #6583
Align local pre-commit with CI-based linting (Tox and Travis) #6583
Conversation
Codecov Report
|
a6a14fd
to
9ad2698
Compare
This is waiting for the other PRs to be merged, only then can we get the green lights from Travis ☁️ 🚥 |
c8681d1
to
9434b34
Compare
Linting overlooked broken rules from previous run of #6583
6021363
to
b74a12b
Compare
e5e9518
to
e246271
Compare
e246271
to
84468b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused how it "knows" to use a py3 venv for black - e.g. where would this be specified?
However I tested with a py2.7 environment and confirmed that it seems to work
I think it's in the hooks configuration: https://github.com/psf/black/blob/master/.pre-commit-hooks.yaml |
Summary
Does anyone else get frustrated when their code breaks a CI linting check because black isn't in pre-commit?
Having it in pre-commit is much faster, as it just lints changed files.
Reviewer guidance
I didn't care to pin the black version. Does it matter?Edit: We use Black without pinning in tox.ini as well, so we always run the latest version.
References
This partly solves #5409
Contributor Checklist
PR process:
Testing:
Reviewer Checklist
yarn
andpip
)