Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert ExamPage BottomAppBar to previous version (0.16.x) #12169

Conversation

nucleogenesis
Copy link
Member

Summary

In light of #12151 this PR reverses changes done in #11658 to the BottomAppBar in ExamPage.

2024-05-13 16 27 56 localhost c34f294aed07

Updated:

image

Reviewer guidance

View the same quiz in 0.16 and this PR and see that the bottom app bar looks the same.

@radinamatic
Copy link
Member

Position of the buttons has been reverted to the previous state. Tested in Firefox and Chrome on Ubuntu 20.04:

2024-05-15_13-27-38

Mentioning again what we discussed recently, that currently is not possible to submit the quiz if there are unanswered questions, which I believe we concluded is an unwarranted limitation. I'm also wondering if the Try again string actually makes sense here at all... 🤔 Try again what? Should be straight Submit , no?
cc @nucleogenesis @tomiwaoLE

2024-05-15_13-31-25

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passes, good to go! 💯 :shipit:

@marcellamaki
Copy link
Member

Yes, it should match the existing workflow, which allows you to "submit quiz" anyways
Screenshot 2024-05-15 at 8 14 15 AM

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reverted code on the bottom bar looks fine, but let's also update the modal (sorry that this was not clear from our chat). Overall the entire workflow for the learner should be the same as it currently is in 0.16.

If we are able to update the workflow for 0.17.0 with Tomiwa's improved design, that's great, but I just want to make sure we don't end up with partial changes that could be more confusing.

Thanks @nucleogenesis ! Glad we're getting this sorted out

@nucleogenesis
Copy link
Member Author

@marcellamaki @radinamatic I tested quizzes on the demo server and saw the "Try again" so I thought I was mimicking the 0.16 version but... turns out the demo server is still 0.15 😅

Just pushed an update to the message and handler for the modal -- now the user can click "Submit Quiz" in the modal to submit an unfinished exam.

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me once QA team approves! 🎉

@radinamatic
Copy link
Member

Good ol' 0.16 quiz is back! 💯 :shipit:

Submit Report
2024-05-16_13-54-46 2024-05-16_13-55-32

@nucleogenesis nucleogenesis dismissed marcellamaki’s stale review May 16, 2024 16:16

This looks fine to me once QA team approves! 🎉 - Marcella in a comment above & QA approved

@nucleogenesis nucleogenesis merged commit 2310ad4 into learningequality:develop May 16, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend SIZE: medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants