Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Python dependencies #12165

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

rtibbles
Copy link
Member

Summary

  • Upgrades all Python dependencies to the latest version that supports Python 3.6
  • Note that it does not upgrade the Python redis library as far as it could go, because the django-redis-cache library we are using requires a redis version less than 4

References

Because we are still supporting EOL Python versions, we have to do these upgrades manually rather than relying on dependabot

Reviewer guidance

First we check if the tests pass, then a smoke test of the asset is in order, particularly testing Redis caching.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: small labels May 13, 2024
@rtibbles rtibbles marked this pull request as ready for review May 14, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants