Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add progress animations #521

Merged
merged 4 commits into from Nov 1, 2022
Merged

Re-add progress animations #521

merged 4 commits into from Nov 1, 2022

Conversation

bartekpacia
Copy link
Contributor

@bartekpacia bartekpacia commented Oct 25, 2022 •
edited

The bug in mason_logger was fixed in felangel/mason#549, so I'm bringing the animations back.

Animations were removed in #498.

@github-actions github-actions bot added the package: patrol_cli Related to the patrol_cli package label Oct 25, 2022
@bartekpacia
Copy link
Contributor Author

bartekpacia commented Oct 25, 2022 •
edited

Unfortunately it's still not ideal, but much better than before:

Screenshot 2022-10-26 at 1 21 13 AM

Gotta decide whether this is good enough.

@bartekpacia bartekpacia changed the title Re-add animated progress animations Re-add progress animations Oct 26, 2022
@bartekpacia bartekpacia merged commit 75b1c89 into master Nov 1, 2022
@bartekpacia bartekpacia deleted the chore/use_mason_logger_again branch November 1, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: patrol_cli Related to the patrol_cli package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bartekpacia