Add support for various features and fixes #583
Conversation
Fixes to resolve issues such as using the parent selector in assigns, ability to use bracketed lists, the proper use for double ampersands (using interpolation), correct selectors for @at-root and better finding of variables from within nested mixins.
| @@ -316,16 +316,9 @@ protected function makeOutputBlock($type, $selectors = null) | |||
| $out->parent = $this->scope; | |||
| $out->selectors = $selectors; | |||
| $out->depth = $this->env->depth; | |||
|
|
|||
There was a problem hiding this comment.
Is this intentional? It appears to revert the fix for #570
| @@ -775,22 +768,50 @@ protected function compileDirective(Block $block) | |||
| */ | |||
| protected function compileAtRoot(Block $block) | |||
| { | |||
|
|
|||
There was a problem hiding this comment.
It would be nice if you update your PR WRT PSR2.
In addition:
- avoid extraneous blank lines,
- space after
foreachkeyword
| @@ -1620,12 +1724,40 @@ protected function compileChild($child, OutputBlock $out) | |||
|
|
|||
| case Type::T_ASSIGN: | |||
| list(, $name, $value) = $child; | |||
| $stups = $value[0]; | |||
There was a problem hiding this comment.
$stups appears to be unused
| @@ -2701,9 +2838,7 @@ public function compileValue($value) | |||
| $b = round($b); | |||
|
|
|||
| if (count($value) === 5 && $value[4] !== 1) { // rgba | |||
| $a = new Node\Number($value[4], ''); | |||
There was a problem hiding this comment.
Is this intentional? It appears to revert the fix for #573
| @@ -3714,7 +3879,7 @@ protected function sortArgs($prototype, $args) | |||
| $key = $key[1]; | |||
|
|
|||
| if (empty($key)) { | |||
| $posArgs[] = empty($arg[2]) ? $value : $arg; | |||
There was a problem hiding this comment.
Is this intentional? It appears to revert the fix for #569
| @@ -4358,7 +4505,7 @@ protected function libRgb($args) | |||
| protected function libRgba($args) | |||
| { | |||
| if ($color = $this->coerceColor($args[0])) { | |||
|
Hey, it appears that somehow I have got a branch out of date here. Let me go back and review what's happened and merge my changes with the most up to date version, I'll make a new set of pull requests. |
|
@niaccurshi Were you able to fix |
|
It seems that I still see this odd error using the update: |
|
I don't know that what I was altering had any bearing on that particular problem. My changes fix a range of issues that are present, but certainly not all. |
|
Sorry, I realise I'm in the wrong thread here, see #593 for the updated changes. |
references #310, #558, #556, #577 and at least some of #511, wide changes to primarily aid parent selectors and @at-root