Skip to content

Commit

Permalink
Don't set SO_REUSEPORT on Windows (hazelcast#23947) [5.3.z]
Browse files Browse the repository at this point in the history
  • Loading branch information
ldziedziul committed Sep 7, 2023
1 parent 0aa2713 commit f1aad4c
Showing 1 changed file with 10 additions and 1 deletion.
Expand Up @@ -18,12 +18,14 @@

import com.hazelcast.internal.tpcengine.net.AsyncSocketOptions;
import com.hazelcast.internal.tpcengine.Option;
import com.hazelcast.internal.tpcengine.util.OS;

import java.io.IOException;
import java.io.UncheckedIOException;
import java.net.SocketOption;
import java.net.StandardSocketOptions;
import java.nio.channels.ServerSocketChannel;
import java.util.Set;

import static com.hazelcast.internal.tpcengine.util.Preconditions.checkNotNull;
import static com.hazelcast.internal.tpcengine.util.ReflectionUtil.findStaticFieldValue;
Expand All @@ -36,6 +38,7 @@ public class NioAsyncServerSocketOptions implements AsyncSocketOptions {
// This option is available since Java 9, so we need to use reflection.
private static final SocketOption<Boolean> STD_SOCK_OPT_SO_REUSEPORT
= findStaticFieldValue(StandardSocketOptions.class, "SO_REUSEPORT");
private static final Set<SocketOption<?>> WINDOWS_UNSUPPORTED_OPTIONS = Set.of(StandardSocketOptions.SO_REUSEPORT);

private final ServerSocketChannel serverSocketChannel;

Expand Down Expand Up @@ -64,7 +67,13 @@ public boolean isSupported(Option option) {
}

private boolean isSupported(SocketOption socketOption) {
return socketOption != null && serverSocketChannel.supportedOptions().contains(socketOption);
if (socketOption == null) {
return false;
}
if (OS.isWindows() && WINDOWS_UNSUPPORTED_OPTIONS.contains(socketOption)) {
return false;
}
return serverSocketChannel.supportedOptions().contains(socketOption);
}

@Override
Expand Down

0 comments on commit f1aad4c

Please sign in to comment.