Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blocked and filtered reducers/selectors/actions. #7682

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Ruk33
Copy link
Collaborator

@Ruk33 Ruk33 commented Aug 30, 2022

Fixes

Issue Number: #7681

What is the current behavior?

What is the new behavior?

blocked & filtered actions/selector/reducers were removed.
Also, if there is a censor reason, we will display it.

image

If no message is present, the default one will be used
("Your hub has blocked this content because it subscribes to the following blocking channel:")

Other information

PR Checklist

Toggle...

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I added a line describing my change to CHANGELOG.md
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

Copy link
Member

@jessopb jessopb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I don't think there's any reason to leave those empty arrays in. Removing them can only simplify the related components. Yes?

ui/page/channel/index.js Outdated Show resolved Hide resolved
ui/component/collectionPreviewTile/index.js Outdated Show resolved Hide resolved
flow-typed/Claim.js Show resolved Hide resolved
Copy link
Member

@jessopb jessopb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the linter complaining:

Error --------------------------------------------------------------------------------- ui/redux/actions/claims.js:93:22

Cannot get `uriResolveInfo.error.censor` because property `censor` is missing in mixed [1].

   ui/redux/actions/claims.js:93:22
   93|                   ...uriResolveInfo.error.censor,
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^

References:
   /tmp/flow/flowlib_61141ec/core.js:48:51
   48|     static entries(object: mixed): Array<[string, mixed]>;
                                                         ^^^^^ [1]


Error --------------------------------------------------------------------------------- ui/redux/actions/claims.js:94:25

Cannot get `uriResolveInfo.error.text` because property `text` is missing in mixed [1].

   ui/redux/actions/claims.js:94:25
   94|                   text: uriResolveInfo.error.text,
                               ^^^^^^^^^^^^^^^^^^^^^^^^^

References:
   /tmp/flow/flowlib_61141ec/core.js:48:51
   48|     static entries(object: mixed): Array<[string, mixed]>;
                                                         ^^^^^ [1]
                                                         ```

@Ruk33
Copy link
Collaborator Author

Ruk33 commented Sep 12, 2022

Thank you @jessopb, sadly I couldn't fix it without using // $FlowFixMe. Not ideal but it gets rid of the warning.

I tried typecasting but it kept complaining about not being compatible with mixed

@jessopb
Copy link
Member

jessopb commented Sep 19, 2022

This will be merged when infrastructure is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants