Mac Catalyst fixes for Apple Silicon #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehardy
reviewed
May 3, 2022
|
|
||
| # XCFramework | ||
| rm -rf "${BASE_PWD}/Frameworks/${FWNAME}.xcframework" | ||
| -destination 'platform=macOS,arch=x86_64,variant=Mac Catalyst' \ |
There was a problem hiding this comment.
this is fascinating, how is this working with arm64 when the arch is specifically x86_64 !?
mikehardy
reviewed
May 3, 2022
| -framework "Frameworks/iphoneos.xcarchive/Products/Library/Frameworks/${FWNAME}.framework" \ | ||
| -framework "Frameworks/iphonesimulator.xcarchive/Products/Library/Frameworks/${FWNAME}.framework" \ | ||
| -framework "Frameworks/maccatalyst.xcarchive/Products/Library/Frameworks/${FWNAME}.framework" \ | ||
| -output "${BASE_PWD}/Frameworks/${FWNAME}.xcframework" |
There was a problem hiding this comment.
I'm also very curious why directory flattening is not needed now but was needed prior 🤔 - I'm pretty sure I'm the source of that flattening code from a year or two back and in my experimentation it was literally the only thing that worked. I believe that was on Xcode 12.4 to start with, before M1 existed. Perhaps the tooling changed a bit. Either way if this actually works for both intel and arm64 macs at the same time, fantastic!
|
Many thanks @Arkkeeper for submitting this PR. I've manually integrated the changes in 095a163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've edited archive-xcframework.sh in order to change the way xcframework built and to disable slice flattening.
Now xcframework is compatible with Mac Catalyst both on x86_64 and arm64 architectures.
This PR fixes bugs described here facebook/flipper#3117