Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to Fitter.custom_plot #412

Merged
merged 11 commits into from
May 22, 2024
Merged

updates to Fitter.custom_plot #412

merged 11 commits into from
May 22, 2024

Conversation

jvavrek
Copy link
Contributor

@jvavrek jvavrek commented May 13, 2024

  1. option to plot without drawing the additional fit info panel
  2. remove hardcoded margin settings
  3. remove savefname kwarg
  4. associated notebook and docstring updates

@jvavrek jvavrek self-assigned this May 13, 2024
@jvavrek jvavrek marked this pull request as draft May 13, 2024 17:57
@jvavrek
Copy link
Contributor Author

jvavrek commented May 13, 2024

From the updated fitting.ipynb, the new custom_plot (using a user-defined figsize, disabling the fit info panel, and calling plt.tight_layout()) now looks like this:
image

@jvavrek
Copy link
Contributor Author

jvavrek commented May 13, 2024

Should we also get rid of the title* kwargs? They only appear in the following line

# Set fig title
if title is not None:
    fig.suptitle(
        str(title), fontweight=title_fontweight, fontsize=title_fontsize
    )

which is normally left to the user to handle.

@markbandstra
Copy link
Member

Should we also get rid of the title* kwargs? They only appear in the following line

# Set fig title
if title is not None:
    fig.suptitle(
        str(title), fontweight=title_fontweight, fontsize=title_fontsize
    )

which is normally left to the user to handle.

Yes, let's leave it to the user, so long as they can access fig.

@jvavrek jvavrek marked this pull request as ready for review May 22, 2024 20:57
@jvavrek jvavrek merged commit 2543879 into main May 22, 2024
22 checks passed
@jvavrek jvavrek deleted the custom-plot-updates branch May 22, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants