Switch code formatting and linting to ruff #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also need to disable refurb since it only seems to run when preview=True
cosama
approved these changes
Apr 10, 2024
Seemed to be causing confusing errors by formatting code during CI and then throwing errors on the formatted code.
All changes convert old-style string formatting to f-strings
Missed this earlier. Also it probably should have been in req-dev.
This reverts commit d1cb99f.
jvavrek
reviewed
May 25, 2024
Seems to work in python 3.11 and 3.12 but not earlier
jvavrek
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all code formatting and linting to using ruff, which is much faster than the existing tools and includes all of the functionality of
black,flake8,isort, and others.Fixes #397