Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider moving all linting and formatting to ruff #397

Closed
markbandstra opened this issue Feb 21, 2024 · 3 comments · Fixed by #398
Closed

Consider moving all linting and formatting to ruff #397

markbandstra opened this issue Feb 21, 2024 · 3 comments · Fixed by #398

Comments

@markbandstra
Copy link
Member

It appears that ruff has become the new standard for linting and formatting code, and it is incredibly fast. Various prominent projects are already using ruff, and we should consider it.

I noticed that one common tool, pydocstyle, recently became retired and now points to ruff as a replacement.
@markbandstra markbandstra mentioned this issue Feb 24, 2024
Merged
@jccurtis
Copy link
Collaborator

Hey @markbandstra, need some help with this?

@markbandstra
Copy link
Member Author

Hi @jccurtis ! Sure, I was having trouble today figuring out exactly what is going wrong with the tests on #398, so if you have spare cycles, that would be helpful!

@markbandstra
Copy link
Member Author

Actually I ended up figuring the problem out, it was a subtlety in using pytest-ruff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch code formatting and linting to ruff lbl-anp/becquerel
2 participants
@markbandstra @jccurtis