Desktop: Fixes #3569: Show full folder name in mouse-over pop-up text

[Jumanjii]

fixes #3569

Defining the tooltip property here, it is then propagated to the ToolbarButton component that will use it to define the html title of the tag while keeping the truncated version as content.

const tooltip = this.props.tooltip ? this.props.tooltip : title;

https://github.com/laurent22/joplin/blob/dev/ElectronClient/gui/ToolbarButton.jsx#L11

[laurent22]

Looks good but please remove the comma changes. It can cause unnecessary conflicts.

[laurent22]

Please remove these changes

[Jumanjii]

My bad, I will update it tonight.
I thought it was the linter hook that added it but it was probably just my editor 😄

[Jumanjii]

Ok, so it was really the husky linter hook that added them and to push without them as you recommend,
I had to temporarily delete the hook from the package.json.

Totally new on the project so tell me if I should have use another easier solution 😸

Running npm lint from the root of the repository to test, it updated 65 files.
Did I miss a configuration somewhere?

[laurent22]

Thanks for the update. Indeed we have a rule for this so I didn't understand why would the linter change the code for you but not for me or other developers.

It seems the reason is that eslint messed up an update and passed a breaking change as a minor version: eslint/eslint#13166 So probably you got the minor version update and I'm still on the previous version. So in the end your change was correct and once I update eslint too, I'll apply the update the whole code base.

Anyway, your main change is good so let's merge!