ci: Add SSE contract test support #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eli-darkly
requested review from
keelerm84,
bwoskow-ld and
louis-launchdarkly
eli-darkly
changed the base branch from
master
to
eb/sc-136139/jruby-9.2-tests
keelerm84
reviewed
Dec 30, 2021
contract-tests/stream_entity.rb
Outdated
Comment on lines
8
to
9
| streams = {} | ||
| streamCounter = 0 |
There was a problem hiding this comment.
I don't think these two are needed anymore.
There was a problem hiding this comment.
Indeed, that's a copy-paste mistake.
Co-authored-by: Matthew M. Keeler <keelerm84@gmail.com>
keelerm84
approved these changes
Dec 30, 2021
keelerm84
requested review from
a team
and removed request for
bwoskow-ld and
louis-launchdarkly
|
I have updated this PR so it runs on GH actions instead of circleci. The problems Eli mentioned still seem to be present, so I've just disabled the contract tests in jruby for now. Might as well get some value from them now instead of waiting until the jruby stuff gets resolved (if it ever does). |
cwaldren-ld
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/launchdarkly/sse-contract-tests
An example of this running in CI is here. That workflow is currently failing due to problems that appear to be JRuby-specific (see below); in all of the non-JRuby jobs, everything passes and I believe the SSE implementation is now fully compliant with spec.
The two kinds of failures I'm seeing in JRuby (which I haven't yet filed separate stories for, because they're so odd that I need to rule out problems in the test logic first) appear to be problems in HTTP client behavior, not in SSE parsing:
If we can fix those, then we will have much better test coverage in JRuby than before, since as described in #27, the mechanism we've been using to do end-to-end HTTP tests within the unit tests for this project was extremely unreliable in JRuby.
If you'd like to test this locally in any version of Ruby, clone this repo and also https://github.com/launchdarkly/sse-contract-tests. In ruby-eventsource, run
make build-contract-testsand thenmake start-contract-test-service. Then, in sse-contract-tests, runmakeand then./sse-contract-tests -url http://localhost:8000- that's it.