pool fixes and breaking changes #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
force-pushed
the
ab/fix-pool
branch
7 times, most recently
from
14f8f3c
to
cd78d7d
Compare
* Fixed leak of `Arc<SharedPool>` in `DecrementSizeGuard::cancel()` * Renamed `PoolOptions::connect_timeout` to `acquire_timeout` for clarity. * Fixed `/* SQLx ping */` showing up in Postgres query logs * Made `.close()` a regular function that returns a `Future` * Deleted deprecated method `PoolConnection::release()` * Document why connection might be dropped if `Pool::acquire()` is cancelled * Added connection metadata to pool lifecycle callbacks * Improved guarantees for `min_connections` * Fixed `num_idle()` to not spin forever at high load * Improved documentation across the `pool` module
abonander
changed the title
This was referenced Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arc<SharedPool>inDecrementSizeGuard::cancel()PoolOptions::connect_timeouttoacquire_timeoutfor clarity./* SQLx ping */showing up in Postgres query logs.close()a regular function that returns aFuturePoolConnection::release()Pool::acquire()is cancelledmin_connectionsnum_idle()to not spin forever at high loadpoolmoduleCloses #1869
Closes #1862
Closes #1824
Closes #1743
Closes #561