Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SQLx dependency to 0.6.x #356

Closed
5 tasks done
billy1624 opened this issue Jun 21, 2022 · 12 comments
Closed
5 tasks done

Upgrade SQLx dependency to 0.6.x #356

billy1624 opened this issue Jun 21, 2022 · 12 comments

Comments

@billy1624
Copy link
Member

billy1624 commented Jun 21, 2022

Motivation

Upgrading SQLx dependency as well as the downstream dependencies such as time, uuid, bigdecimal, etc.

Tasks

Additional Information

Potential Breaking Changes

@ikrivosheev
Copy link
Member

@billy1624 please, add bigdecimal to Tasks.

@billy1624
Copy link
Member Author

Hey @ikrivosheev, feel free to edit my comment :)

@ikrivosheev
Copy link
Member

@billy1624 @tyt2y3 I think we need to agree! Support both time, uuid, bigdecimal versions or support only latest?

@tyt2y3
Copy link
Member

tyt2y3 commented Jul 1, 2022

I think we should only support latest

@ikrivosheev
Copy link
Member

@tyt2y3 sounds good

@tyt2y3
Copy link
Member

tyt2y3 commented Jul 1, 2022

Okay. So after some thought, I think our dependency policy would be follows: we only support the latest release of an upstream dependency, and in SeaORM we simply follow whatever version SQLx uses.

So in some cases, we need to maintain a branch of sea-query to support sea-orm while sea-query keep upgrading dependencies even before SQLx upgrades them

@tyt2y3
Copy link
Member

tyt2y3 commented Jul 1, 2022

I realize that it's a much less maintenance burden to backport features to an older branch than to trying to make it all work together in one codebase, given that in practice, no meaningful code change is required to switch dependency version (for the most part they compile!).

@tyt2y3
Copy link
Member

tyt2y3 commented Jul 1, 2022

So at any time we only maintain two sea-query branches, the latest master and whatever version sea-orm is pinned to.

@ikrivosheev
Copy link
Member

@tyt2y3 I add PR

@ikrivosheev
Copy link
Member

@tyt2y3 I think we can close this issue, because sqlx is upgraded.

@tyt2y3
Copy link
Member

tyt2y3 commented Jul 1, 2022

So cool, I am waiting the moment the CI passes

@ikrivosheev
Copy link
Member

Cool! CI pass: https://github.com/SeaQL/sea-query/actions/runs/2596551981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants