Skip to content

Commit

Permalink
fix(cli): pin clap_derive version (#1381)
Browse files Browse the repository at this point in the history
When `clap_derive 3.0.0-beta.4` released, new invocations of `cargo install sqlx-cli` would try to compile that against `clap 3.0.0-beta.2` which caused some breakages.

Until `clap 3.0.0` proper is released, we need to pin both versions to insure against potential breakages from automatic upgrades.

closes #1378
  • Loading branch information
abonander committed Aug 16, 2021
1 parent dd27aa0 commit 38435ca
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
9 changes: 5 additions & 4 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions sqlx-cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,11 @@ sqlx = { version = "0.5.5", path = "..", default-features = false, features = [
"offline",
] }
futures = "0.3"
# FIXME: we need to fix both of these versions until Clap 3.0 proper is released, then we can drop `clap_derive`
# https://github.com/launchbadge/sqlx/issues/1378
# https://github.com/clap-rs/clap/issues/2705
clap = "=3.0.0-beta.2"
clap_derive = "=3.0.0-beta.2"
chrono = "0.4"
anyhow = "1.0"
url = { version = "2.1.1", default-features = false }
Expand Down

0 comments on commit 38435ca

Please sign in to comment.