Error check improvement #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An experienced customer experiemented with the CLI locally to try out a new command. Upon seeing the --session option, they assumed they just need to pass a test session ID, so they ended up invoking something like `launchable foo bar --session 12345` That is a good assumption on their part, but it's actually incorrect, as the ID format we take is more complicated. However, there's no error check, so the CLI resulted in 404, which misled them. By adding parse_session, we can make sure the ID given from the command line is in the correct format, and fail gracefully if not.
kohsuke
force-pushed
the
session-error-check
branch
from
71a0ff2
to
c5a08f7
Compare
|
Konboi
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An experienced customer experiemented with the CLI locally to try out a new command. Upon seeing the --session option, they assumed they just need to pass a test session ID, so they ended up invoking something like
launchable foo bar --session 12345That is a good assumption on their part, but it's actually incorrect, as the ID format we take is more complicated. However, there's no error check, so the CLI resulted in 404, which misled them.
By adding parse_session, we can make sure the ID given from the command line is in the correct format, and fail gracefully if not.