httpc #129
Open
httpc #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am aware of the ssl issue but I am under the impression I can grab it from ssl module stdlib. Either way it will be an adventure
With one minor exception. I have added the cacert file that curl uses, which in turn is built from firefox. It does add a little weight to the priv directory but the file revs very infrequently (about 3 times a year) and is easy to maintain. I am unsure at present what happens when the cacert file falls out of date. More info here. https://curl.haxx.se/docs/caextract.html
Replaces all hackney calls in dataloader module with httpc based client. Tested a Man in The Middle attach and the ssl cert thing seems to work. There was a concious effort to change as little code as possible in data loader but I made the call to switch the header filter to charlists rather than iterate over the httpc header return values as that seemed silly.
The issue has been corrected.
Just a brief and first draft of a file to explain the need and the how of the cacert.pem file.
Also other supporting libraries than are now in the vm
|
Also if we are willing to make future version as otp 25 and above I can just grab the os provided cacert in an easier to implement cross platform way. |
|
🚀🌈🍈 would love to see this in a future tzdata release. httpc is ideally placed to do this and provide all the cert checking we expect, without introducing dependencies. |
|
I would love to see this too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was doing something today and noticed @wojtekmach in #123 and I had most of the code already. Just unsure if we want to drop hackney completely or continue with the callback implementation. So I updated to latest and rejiggered the code but if I can a little direction here how we want to move forward I can move some code around.