Skip to content

Commit

Permalink
Changed test script filename for travis ci
Browse files Browse the repository at this point in the history
  • Loading branch information
lastzero committed Feb 4, 2017
1 parent 8769a67 commit dd3fc58
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .travis.yml
Expand Up @@ -10,4 +10,4 @@ before_script:
- composer install

script:
- phpunit
- bin/phpunit

7 comments on commit dd3fc58

@TomasVotruba
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, why do you use this instead of classic vendor/bin/phpunit?

@lastzero
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're using bin/ for all of our projects... it's less typing and people who are not familiar with composer / the vendor directory see it without further instructions. After all, it doesn't hurt :)

@TomasVotruba
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not phpunit then?

@lastzero
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put everything in the main directory?

@TomasVotruba
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Travis default

@lastzero
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That means, you don't know which PHPUnit version you're actually using.

See also:

sebastianbergmann/phpunit#2015 (comment)

Money quote: "In a scenario such as the one you describe you have to install PHPUnit via Composer for the time being."

@TomasVotruba
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks

Please sign in to comment.