[8.x] Revert "[8.x] Run observer callbacks after database transactions have committed"

[driesvints]

Reverts #436

I'm reverting this because this causes test suites that have the DatabaseTransactions trait applied to fail.

Fixes #437

[taylorotwell]

Personally I think this may need to be fixed at the framework level.

[bakerkretzmar]

I think the original issue and bug are more important: Scout should not sync model data to a search index until that data has been persisted into the database. Reverting this would re-break tons of apps using Scout and database transactions (including Nova).

I appreciate where that issue is coming from but that's the expected behaviour, and it can easily be fixed by removing DatabaseTransactions or RefreshDatabase from that specific test.

I agree that it would make a lot of sense for this to be more flexible in the long run.

[driesvints]

I'm going to close this because I agree this probably isn't a fix in the long run.

and it can easily be fixed by removing DatabaseTransactions or RefreshDatabase from that specific test.

How would someone run their tests against a database then?

[bakerkretzmar]

@driesvints thanks!

How would someone run their tests against a database then?

With the DatabaseMigrations trait I think? I've done this before when I had issues with transactions, it's slower and leaves test data in the database but other than that it works fine. Definitely not a perfect solution but it should do the trick for now.

[taylorotwell]

I went ahead and reverted this. I would like to see it be configurable. You can also force Scout stuff to be update after commits by using Scout's queue configuration option and setting your queue connection to use after_commit.