[8.x] Call values() after shouldBeSearchable()

[michalisantoniou6]

If $models->filter->shouldBeSearchable() returns a collection that does not start on index 0 it causes error below.

[driesvints]

Probably needs laravel/framework#32747 as an alternative fix.

[cstriuli]

@driesvints using shouldBeSearchable() with a Pivot Model (Illuminate\Database\Eloquent\Relations\Pivot) get an similar error

You can check the class Illuminate\Database\Eloquent\Relations\ConcernsAsPivot::newQueryForCollectionRestoration that needs an array as argument starting with 0 but using (and filtering) shouldBeSearchable in a Pivot Model fails because gets an array starting with a number greater than 0.

• PHP version: 7.4.11
• Scout version: ^8.3
• Laravel version: ^8.3
• Queue connection: redis
• Scout driver: algolia

Failed artisan scout:reimport (with shouldBeSearchable):

Failed Job:

Success artisan scout:reimport (without shouldBeSearchable):

English is not my mother tongue; sorry for any mistake on my part

[driesvints]

@cstriuli can you open up an issue on the laravel/framework repo with the full stacktrace?

[cstriuli]

Done: laravel/framework#35210