Check if $tokenable is valid by checking whether it implements HasApiTokens contract #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could be a breaking change. |
|
@taylorotwell It definitely is. So are you saying "maybe" in the next major version? Or are you saying it's not even "worth" it (for now)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if $tokenable is valid by checking whether it implements HasApiTokens contract instead of checking the specific (trait) implementation.
This relates to #506.
If this is acceptable, with or without more changes, it would also require an update to the docs page. This is because you would have to explicitly implement the
HasApiTokens-interface and not just use theHasApiTokens-trait.