Sanctum configuration value missing #492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the `SanctumServiceProvider`, the route prefix for sanctum is used from the config value `('sanctum.prefix')` but that value is not actually in the config file.
this PR adds that value so customization can be done with less confusion.
https://github.com/laravel/sanctum/blob/02ceac431eb99e7cf1d863e3fc4d3e72750cc720/src/SanctumServiceProvider.php#L86C43-L86C57
### TODO
- [ ] Add proper cascading comment block in config.
|
I personally don't really think this should be changed, so I didn't expose it in the configuration file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
in the
SanctumServiceProvider, the route prefix for sanctum is used from the config value('sanctum.prefix')but that value is not actually in the config file.Solution
Users are unable to find the value in the config, although adding it is simple, it would make sense to provide all configuration values with their defaults in the published config file for ease of use and better DX.
this PR adds that value so customization can be done with less confusion.
https://github.com/laravel/sanctum/blob/02ceac431eb99e7cf1d863e3fc4d3e72750cc720/src/SanctumServiceProvider.php#L86C43-L86C57
TODO