Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migration's primary identifier change #386

Merged
merged 1 commit into from Jul 29, 2022
Merged

Update migration's primary identifier change #386

merged 1 commit into from Jul 29, 2022

Conversation

suyar
Copy link
Contributor

@suyar suyar commented Jul 29, 2022

This is the migration file in laravel:
2019_12_14_000001_create_personal_access_tokens_table.php

....
Schema::create('personal_access_tokens', function (Blueprint $table) {
    $table->id();
...

This is the migration file in sanctum:
2019_12_14_000001_create_personal_access_tokens_table.php

...
Schema::create('personal_access_tokens', function (Blueprint $table) {
    $table->bigIncrements('id');
...

I think the id field should be kept consistent.

@driesvints
Copy link
Member

I think we couldn't do this before with Sanctum supporting older versions but seems to be okay now.

@driesvints driesvints changed the title The migration fields are consistent with laravel/laravel. Update migration's primary identifier change Jul 29, 2022
@taylorotwell taylorotwell merged commit ce4bd7b into laravel:3.x Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants