Skip to content

Commit

Permalink
Bump dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
driesvints committed Feb 21, 2020
1 parent 18e33ab commit 0d9a007
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Expand Up @@ -14,7 +14,7 @@ jobs:
fail-fast: true
matrix:
php: [7.2, 7.3, 7.4]
laravel: [6.*, 7.*]
laravel: [^6.0, ^7.0]

name: P${{ matrix.php }} - L${{ matrix.laravel }}

Expand All @@ -32,7 +32,7 @@ jobs:
uses: shivammathur/setup-php@v1
with:
php-version: ${{ matrix.php }}
extension-csv: dom, curl, libxml, mbstring, zip, pcntl, pdo, sqlite, pdo_sqlite, bcmath, soap, intl, gd, exif, iconv, imagick
extensions: dom, curl, libxml, mbstring, zip, pcntl, pdo, sqlite, pdo_sqlite, bcmath, soap, intl, gd, exif, iconv, imagick
coverage: none

- name: Install dependencies
Expand Down
3 changes: 2 additions & 1 deletion composer.json
Expand Up @@ -29,8 +29,9 @@
"illuminate/support": "^6.0|^7.0",
"laminas/laminas-diactoros": "^2.2",
"league/oauth2-server": "^8.0",
"nyholm/psr7": "^1.0",
"phpseclib/phpseclib": "^2.0",
"symfony/psr-http-message-bridge": "^1.0"
"symfony/psr-http-message-bridge": "^2.0"
},
"require-dev": {
"mockery/mockery": "^1.0",
Expand Down

1 comment on commit 0d9a007

@iBotPeaches
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hiya @driesvints,

This change was probably intended, but it did break a bit for me for a minor patch so wanted to run it by you.

We locked a specific Laravel version but not Passport, so moving up Passport to latest Passport broke as the minimum requirement for Passport is now 6.10+ or 7.0+, since the PSR Factory changes only occurred in 6.10 - laravel/framework#31018, but I was stupidly locked on an old Laravel 6 version.

Okay, so easy. Update Laravel and Passport together (6 latest and Passport 8 latest), until I ran into another issue. Passport removed the DiactorosFactory by upgrading to symfony/psr-http-message-bridge (2.0) https://github.com/symfony/psr-http-message-bridge/blob/master/CHANGELOG.md#200-2020-01-02 under the hood. This affected some my code and other 3rd party dependencies.

It was the only change, so the upgrade was just to remove deprecated stuff (If I'm understanding correctly) as part of this commit.

So in the release notes for Laravel 7 there were major package upgrades for affected projects. Shouldn't Passport have bumped to 9.x with this change in it? That way 8.x would have remained on the older psr message bridge.

Please sign in to comment.