Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to stuck in "Application change detected. Restarting workers" with Octane + FrankenPHP + Sail. #890

Merged
merged 1 commit into from
May 16, 2024

Conversation

gazzoy
Copy link
Contributor

@gazzoy gazzoy commented May 14, 2024

This pull request seeks to fix #884.

The actual bug is, when we use Octane + FrankenPHP + Sail, along with env XDG_CONFIG_HOME:/var/www/html/config, FrankenPHP generates and updates /var/www/html/config/caddy/autosave.json automatically. Therefore, we see continuous "Application change detected. Restarting workers" message and process would be stucked.

This fix would ignore the case.

@taylorotwell taylorotwell merged commit 59e1201 into laravel:2.x May 16, 2024
14 checks passed
@gazzoy gazzoy deleted the fix/watch-config-caddy branch May 17, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Octane + FrankenPHP + Sail, stuck in "Application change detected. Restarting workers"
3 participants