Fix memory leaks #181
Merged
Fix memory leaks #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@themsaid looks like our tests need fixing. |
|
@taylorotwell the PR depends on laravel/framework#36955 so it'll be fixed when we can lock to the release tomorrow. |
albertcht
reviewed
Apr 13, 2021
GrahamCampbell
suggested changes
Apr 13, 2021
| @@ -110,6 +111,11 @@ public function handle(Request $request, RequestContext $context): void | |||
| } catch (Throwable $e) { | |||
| $this->handleWorkerError($e, $sandbox, $request, $context, $responded); | |||
| } finally { | |||
| $sandbox->flush(); | |||
|
|
|||
| $this->app->make('view.engine.resolver')->forget('blade'); | |||
There was a problem hiding this comment.
Is there a way to forget all? If not, could it be added to Laravel today. Otherwise, other custom things will still cause leaks.
albertcht
reviewed
Apr 13, 2021
| @@ -110,6 +111,11 @@ public function handle(Request $request, RequestContext $context): void | |||
| } catch (Throwable $e) { | |||
| $this->handleWorkerError($e, $sandbox, $request, $context, $responded); | |||
| } finally { | |||
| $sandbox->flush(); | |||
There was a problem hiding this comment.
Then it's okay to remove other sandbox' forgetInstance call in FlushTemporaryContainerInstances?
(Not sure if it's necessary to call forgetInstance in FlushAuthenticationState)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes memory leaks in Octane as reported in #171
This will flush the entire sandbox container. This will clear any references to request-content singletons which allows PHP's garbage collector from clearing the memory when
unset($sandbox)is called.These lines deal with a memory leak in facade/ignition as explained in laravel/framework#36955.