[7.x] Fix S3 endpoint url reference #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS SDK doesn't really support the `url` config option, it needs to pass the `endpoint` option instead (https://docs.aws.amazon.com/sdk-for-php/v3/developer-guide/guide_configuration.html#endpoint). Related changes from upstream - laravel/laravel#5267 - laravel/laravel#5276
GrahamCampbell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS SDK doesn't really support the
urlconfig option, it needs to pass theendpointoption instead (https://docs.aws.amazon.com/sdk-for-php/v3/developer-guide/guide_configuration.html#endpoint).Related changes from upstream
This should fix the case where people try to use a S3 compatible service with the default configuration provided by the lumen framework. Otherwise, one needs to add a custom ServiceProvider that uses the appropriate config options.