[4.x] Ability to see which masters are paused and only show paused if everything is paused #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
driesvints
reviewed
Nov 20, 2020
| @@ -74,7 +74,7 @@ public function test_paused_status_is_reflected_if_all_master_supervisors_are_pa | |||
| $masters = Mockery::mock(MasterSupervisorRepository::class); | |||
| $masters->shouldReceive('all')->andReturn([ | |||
| (object) [ | |||
| 'status' => 'running', | |||
| 'status' => 'paused', | |||
There was a problem hiding this comment.
Because now it only will show "paused" if all master supervisorrs are paused. Changed in behaviour because it's now unclear if you look at the dashboard. Now it shows "paused" while only one master supervisor is paused and everything is running. Therefore this pull request to show users (see images) if not all master supervisors are paused or not. Test was failing because he expected to be "paused" if only one is "paused" despite the wrong title that was indicating all master supervisors are paused.
|
This was sent to 4.x branch. The current release of Horizon is 5.x. Please submit to that branch. |
|
Opened a new PR: #929 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does two things:
A couple of images to show what has been changed.
Little question: I wasn't sure if I should update the javascript files by running
npm run production. If necessary, I can make changes.Closes #927