[10.x] WIP #48352
Closed
[10.x] WIP #48352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
reviewed
Sep 11, 2023
| * | ||
| * @param array $results | ||
| * @return array | ||
| */ | ||
| public function processColumnListing($results) | ||
| public function processColumns($results) |
There was a problem hiding this comment.
Changing the behavior of the processColumnListing method on each of these grammars is a breaking change unfortunately. Can we move this to master for Laravel v11?
There was a problem hiding this comment.
@driesvints We can keep them without change if you think it's breaking. I'll push a commit. would you please reopen this and make it draft?
hafezdivandari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP