Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Fix schedule:list crash when call() is given class-string #45306

Merged
merged 2 commits into from Dec 14, 2022
Merged

[9.x] Fix schedule:list crash when call() is given class-string #45306

merged 2 commits into from Dec 14, 2022

Commits on Dec 14, 2022

  1. [9.x] Fix schedule:list crash when call() is given class-string

    When creating schedule of the form:
    
    ```php
            $this->schedule->call(FooCall::class);
            $this->schedule->call([FooCall::class, 'fooFunction']);
    ```
    
    Then the `ScheduleListCommand::getClosureLocation()` method would crash with:
    
    ```
       TypeError
    
      Cannot use "::class" on value of type string
    ```
    
    This PR fixes it by adding checks for string `$callback` and returning that string instead of adding `::class` to it.
    
    Tests for both single string and array callable syntax included.
    Odinn Adalsteinsson committed Dec 14, 2022
    Copy the full SHA
    7a82f4f View commit details
    Browse the repository at this point in the history
  2. Streamlined the array callable fix

    Odinn Adalsteinsson committed Dec 14, 2022
    Copy the full SHA
    79f51e1 View commit details
    Browse the repository at this point in the history