Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Lack of Memory when failing a job with wrong variable passed on the method fail() #45291

Merged
merged 5 commits into from Dec 14, 2022
Merged

Fixed Lack of Memory when failing a job with wrong variable passed on the method fail() #45291

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
232150a
Fixed bug on Batchs Jobs Table
Fairydx Dec 11, 2022
b6c9699
Update batches.stub
taylorotwell Dec 12, 2022
7f867ad
Merge branch 'laravel:9.x' into 9.x
Fairydx Dec 13, 2022
82f9a81
Fixed Lack of Memory when failing a job
Fairydx Dec 13, 2022
10e173b
Update InteractsWithQueue.php
taylorotwell Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Illuminate/Queue/InteractsWithQueue.php
View file
Open in desktop
Expand Up @@ -3,6 +3,8 @@
namespace Illuminate\Queue;

use Illuminate\Contracts\Queue\Job as JobContract;
use InvalidArgumentException;
use Throwable;

trait InteractsWithQueue
{
Expand Down Expand Up @@ -43,8 +45,12 @@ public function delete()
*/
public function fail($exception = null)
{
if ($this->job) {
$this->job->fail($exception);
if ($exception instanceof Throwable || is_null($exception)) {
if ($this->job) {
return $this->job->fail($exception);
}
} else {
throw new InvalidArgumentException('The fail method requires an instance of Throwable.');
}
}

Expand Down