[9.x] Prevent test issues with relations with the $touches property #45118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e causing issues with touched relationships on tests
… touches-relationship-issue
|
@taylorotwell @WendellAdriel this PR breaks factories, it assumes a relation can only ever be a collection, but it can also be a single model. This results in errors like: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on #45064 this is a change that will prevent the issue of an empty relationship when testing models with the
$touchesproperty defined.TBH IDK if this is the expected behaviour so if this is not the best solution, feel free to close the PR or let me know what should I change so the PR can be accepted.